jgeorgi/GlModelViewer
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Refactor js files #48

Merged
jgeorgi merged 3 commits from bas-js-refact into main 2024-11-18 03:54:29 +00:00
Conversation 0 Commits 3 Files Changed 5 +677 -616
jgeorgi commented 2024-11-18 03:54:17 +00:00
Owner
Copy Link

This pr is a significant reorg of the js files.

  1. All non-basic functions have been moved out of the main glmv.js
  2. 'Metadata' has been universally changed to mvconfig to avoid conflict with actual file metadata
  3. Configuration changing functions have been split off into glmv-mvconfig.js
  4. Hotspot modification functions have been split off into glmv-hs.js
This pr is a significant reorg of the js files. 1) All non-basic functions have been moved out of the main glmv.js 2) 'Metadata' has been universally changed to mvconfig to avoid conflict with actual file metadata 3) Configuration changing functions have been split off into glmv-mvconfig.js 4) Hotspot modification functions have been split off into glmv-hs.js
jgeorgi added 3 commits 2024-11-18 03:54:17 +00:00
Convert preview menu buld to function a801e362d9 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Refactor preview vs non preview js 816fc9628b 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Subdivide preview js files by function 741f62ea9c 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
jgeorgi merged commit 0dd9aba2b6 into main 2024-11-18 03:54:29 +00:00
jgeorgi deleted branch bas-js-refact 2024-11-18 03:54:29 +00:00
jgeorgi referenced this issue from a commit 2024-11-18 03:54:31 +00:00
Refactor js files (#48)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jgeorgi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jgeorgi/GlModelViewer#48
No description provided.
Delete Branch "bas-js-refact"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?