jgeorgi/GlModelViewer
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Convert configs from json to toml #58

Merged
jgeorgi merged 5 commits from toml_annot into main 2025-05-02 03:54:19 +00:00
Conversation 0 Commits 5 Files Changed 8 +1203 -33
jgeorgi commented 2025-05-02 03:54:08 +00:00
Owner
Copy Link

This PR converts the configuration syntax in the files description page from json to the more user friendly toml. PHP toml handling is performed by the Devium toml library and javascript toml handling is via the smol-toml node package (merged into a single library with ncc).

This will be a breaking change for any model currently loaded with json configs. It is advisable to convert the configs to toml first (which will throw minor errors) and then upgrade.

This PR converts the configuration syntax in the files description page from json to the more user friendly toml. PHP toml handling is performed by the Devium toml library and javascript toml handling is via the smol-toml node package (merged into a single library with ncc). This will be a breaking change for any model currently loaded with json configs. It is advisable to convert the configs to toml first (which will throw minor errors) and then upgrade.
jgeorgi added this to the v0.3.0 milestone 2025-05-02 03:54:08 +00:00
jgeorgi added the
enhancement
 label 2025-05-02 03:54:08 +00:00
jgeorgi added 5 commits 2025-05-02 03:54:09 +00:00
Read toml formatted configs for display 95647069eb 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Add TOML handling to JS modules 5561038c25 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Un-fix: extension.json ea51793e2f 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Restore preview edit functions 9857e77a1a 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Update readme 840b5e34df 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
jgeorgi merged commit a2246015c9 into main 2025-05-02 03:54:19 +00:00
jgeorgi deleted branch toml_annot 2025-05-02 03:54:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone v0.3.0
Projects
Clear projects
No project
Assignees
Clear assignees
jgeorgi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jgeorgi/GlModelViewer#58
No description provided.
Delete Branch "toml_annot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?